[Fixed]-Django ModelChoiceField – use something other than id?

26👍

What about to_field_name? I’m not sure if it’s documented anywhere, but you can find it easily between ModelChoiceField constructor params: https://github.com/django/django/blob/master/django/forms/models.py. It is used to filter field queryset.

For example:

articles = ModelChoiceField(queryset=Articles.objects.all(),
        to_field_name='slug')
👤paluh

1👍

ModelChoiceFields are meant to be used to select between a choice of existing model instances. This is almost always best represented by some form of Select field.

That said do you really have a FK from address to postal_code as you’re implying. What are you storing on a PostalCode table to justify the extra table that will need to be joined in for every address related query?

For most cases postal_code should simply be a CharField and in that case if you want to validate that the value is valid you can use the choices attribute with a list of valid postal codes. Keep in mind that maintaining a list of valid postal codes by hand is a huge hassle.

If you really have a PostalCode table and think it’s a good idea (which in some cases it could be) you may want to consider actually using the postal_code as the primary key rather than the default autoincrement since it’s necessarily unique, makes your data more exportable, and solves your issue with validation.

👤John

1👍

If postal_code is a foreign key to a PostalCode model that contains valid postal codes I would just use use a CharField and then do a clean like you suggested. My clean method would look like this:

def clean_postal_code(self):
    try:
        code = PostalCode.objects.get(code_field=self.data['postal_code'])
    except:
        raise forms.ValidationError("Please enter a valid postal code")
    return code
👤nates

Leave a comment